From fb484db473a97f59bfcad31007ceae2c578d923b Mon Sep 17 00:00:00 2001
From: Fabian Schindler <fabian.schindler.strauss@gmail.com>
Date: Fri, 1 Apr 2022 09:47:50 +0200
Subject: [PATCH] Adding type hints and fixing typing issue
---
registrar/source.py | 2 +-
requirements-dev.txt | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/registrar/source.py b/registrar/source.py
index 2ea8ad1..5f17e0a 100644
--- a/registrar/source.py
+++ b/registrar/source.py
@@ -381,7 +381,7 @@ class HTTPSource(Source):
def get_file(self, path: str, target_path: str):
url = urljoin(self.endpoint_url, path)
response = requests.get(url, allow_redirects=True)
- with open(target_path, "w") as f:
+ with open(target_path, "wb") as f:
f.write(response.content)
@abstractmethod
diff --git a/requirements-dev.txt b/requirements-dev.txt
index d8fa1b7..abc4809 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -4,3 +4,4 @@ mypy==0.910
types-redis
types-PyYAML
+types-requests
--
GitLab